Skip to content

add socket tier 1 reachability analysis - #2634

Merged
fnando merged 4 commits into
stellar:mainfrom
kanwalpreetd:main
Aug 29, 2026
Merged

fnando merged 4 commits into
stellar:mainfrom
kanwalpreetd:main

Conversation

@kanwalpreetd

Copy link
Copy Markdown
Contributor

Copilot AI balanced review requested due to automatic review settings June 29, 2026 19:05
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a scheduled GitHub Actions workflow to run Socket’s “full application reachability” scan against the stellar-cli repo, with a log-based warning mechanism to distinguish Tier 1 reachability from Tier 2 fallback results.

Changes:

  • Introduces a new scheduled + manually dispatchable “Socket reachability scan” workflow.
  • Installs Node + Socket CLI and runs socket scan create --reach, emitting a GitHub Actions warning if Tier 2 fallback markers appear in the output.
  • Sets an environment opt-in to run JS-based actions on Node 24.

Comment thread .github/workflows/socket-scan.yml Resolved
Comment thread .github/workflows/socket-scan.yml Resolved
Comment thread .github/workflows/socket-scan.yml Resolved
Comment thread .github/workflows/socket-scan.yml Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80f2814001

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/socket-scan.yml Resolved
kanwalpreetd and others added 3 commits August 26, 2026 01:41
- Drop the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env block: every action here
  already declares `using: node24`, and runners have defaulted to Node 24
  since 2026-06-16 (Node 20 is removed 2026-09-16)
- Remove the unused Corepack step; corepack only shims yarn/pnpm, and this
  repo uses neither
- Replace dtolnay/rust-toolchain with `rustup update`, matching this repo's
  other workflows and dropping a third-party action from a security workflow.
  This also fixes a real mismatch: the pinned 1.86.0 was below this repo's
  declared MSRV of 1.93.0

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 28, 2026 07:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread .github/workflows/socket-scan.yml Resolved
Comment thread .github/workflows/socket-scan.yml Resolved
Comment thread .github/workflows/socket-scan.yml Resolved
@fnando
fnando merged commit 0cc28fc into stellar:main Aug 29, 2026
228 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants